Add exporter options and other functionality by nikhilNava · Pull Request #63 · microsoft/Agent365-python

nikhilNava · 2025-11-19T19:48:07Z

Task

Add exporter options
Operation source defaults to SDK
New method to baggage properties to set session and channel values
Fix logic to getchannel and sub channel details
Fix logic to get conversation id
Request content is set as input message in invoke scope

Copilot

Pull Request Overview

This PR adds exporter configuration options, sets operation source defaults to SDK, introduces new baggage builder methods for session and channel management, fixes channel/subchannel extraction logic, simplifies conversation ID retrieval, and sets request content as input messages in invoke scope.

Key Changes

Introduced Agent365ExporterOptions class for centralized exporter configuration with batch processor settings
Operation source now defaults to SDK when not specified in baggage
Added new BaggageBuilder methods for session ID/description and channel name/links, with deprecated wrappers for old methods
Simplified conversation ID logic by removing WPX comment and email notification entity handling
Fixed channel extraction to properly handle ChannelId objects with channel and sub_channel properties
Request content is now set as input messages in invoke scope spans

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
test_span_processor.py	Updated tests to verify operation source defaults to SDK and honors baggage values
test_invoke_agent_scope.py	Added comprehensive tests for request attributes on spans including source metadata and input messages
test_baggage_builder.py	Added tests for new session and channel baggage methods
test_agent365.py	Refactored from basic functionality test to comprehensive unittest suite for configuration and exporter options, fixed copyright header
utils.py	Added deprecated decorator utility and migrated to newer OpenTelemetry exception attributes
trace_processor/util.py	Added new session and operation source constants to common attributes, removed deprecated execution source ID
span_processor.py	Implemented operation source defaulting to SDK with baggage override support
request.py	Removed unused payload field from Request dataclass
operation_source.py	New enum for operation source values (SDK, Gateway, MCPServer)
turn_context_baggage.py	Simplified conversation ID extraction, enhanced channel handling for ChannelId objects, removed entity-based logic
baggage_builder.py	Added session and channel methods, deprecated old source_metadata methods, updated operation_source to use enum
invoke_agent_scope.py	Removed execution source ID, added input messages from request content
agent365_exporter_options.py	New configuration class for Agent365Exporter with batch processor settings
constants.py	Added SESSION_DESCRIPTION_KEY, removed GEN_AI_EXECUTION_SOURCE_ID_KEY
config.py	Integrated Agent365ExporterOptions with backward compatibility for legacy parameters

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py

...gents-a365-observability-core/microsoft_agents_a365/observability/core/invoke_agent_scope.py

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py

...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py

.../microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py

...servability-core/microsoft_agents_a365/observability/core/middleware/turn_context_baggage.py

.../microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/config.py

...bservability-core/microsoft_agents_a365/observability/core/trace_processor/span_processor.py

…gents_a365/observability/core/invoke_agent_scope.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…gents_a365/observability/core/exporters/agent365_exporter_options.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2025-11-19T20:10:34Z

@nikhilNava I've opened a new pull request, #64, to work on those changes. Once the pull request is ready, I'll request review from you.

…gents_a365/observability/core/config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

...s/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/utils.py

...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py

...servability-core/microsoft_agents_a365/observability/core/middleware/turn_context_baggage.py

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py

...bservability-core/microsoft_agents_a365/observability/core/trace_processor/span_processor.py

…gents_a365/observability/core/config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2025-11-19T20:13:25Z

@nikhilNava I've opened a new pull request, #65, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py

* Initial plan * Remove redundant condition in _iter_conversation_pairs Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

* Initial plan * Fix copyright header in utils.py to use standard Microsoft format Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py

...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py

nikhilc-microsoft added 2 commits November 19, 2025 12:42

updates to baggage and scope

12aaeaf

add tests for new functionality

9b2473a

Copilot AI review requested due to automatic review settings November 19, 2025 19:48

nikhilNava requested a review from a team as a code owner November 19, 2025 19:48

Copilot started reviewing on behalf of nikhilNava November 19, 2025 19:48 View session

Copilot finished reviewing on behalf of nikhilNava November 19, 2025 19:52

Copilot AI reviewed Nov 19, 2025

View reviewed changes

nikhilc-microsoft and others added 2 commits November 19, 2025 12:59

fix tests

ae1e321

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

da09c7d

…gents_a365/observability/core/invoke_agent_scope.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 19, 2025 20:08

nikhilNava and others added 2 commits November 19, 2025 13:08

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

84099db

…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

b749015

…gents_a365/observability/core/exporters/agent365_exporter_options.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of nikhilNava November 19, 2025 20:09 View session

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

2742afa

…gents_a365/observability/core/exporters/agent365_exporter_options.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot finished reviewing on behalf of nikhilNava November 19, 2025 20:09

Copilot AI mentioned this pull request Nov 19, 2025

Remove redundant null check in conversation ID extraction #64

Merged

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

87f4e34

…gents_a365/observability/core/config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI reviewed Nov 19, 2025

View reviewed changes

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

2d79fe1

…gents_a365/observability/core/config.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 19, 2025 20:11

Copilot started reviewing on behalf of nikhilNava November 19, 2025 20:11 View session

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

d742519

…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Nov 19, 2025

Fix copyright header in utils.py to use standard Microsoft format #65

Merged

Copilot finished reviewing on behalf of nikhilNava November 19, 2025 20:15

Copilot AI reviewed Nov 19, 2025

View reviewed changes

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py Outdated Show resolved Hide resolved

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py Show resolved Hide resolved

Copilot AI and others added 2 commits November 19, 2025 13:18

Copilot AI review requested due to automatic review settings November 19, 2025 20:19

Copilot started reviewing on behalf of nikhilNava November 19, 2025 20:19 View session

Update libraries/microsoft-agents-a365-observability-core/microsoft_a…

3f2fa39

…gents_a365/observability/core/middleware/baggage_builder.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot finished reviewing on behalf of nikhilNava November 19, 2025 20:23

Copilot AI reviewed Nov 19, 2025

View reviewed changes

...65-observability-core/microsoft_agents_a365/observability/core/middleware/baggage_builder.py Show resolved Hide resolved

juliomenendez approved these changes Nov 19, 2025

View reviewed changes

...ability-core/microsoft_agents_a365/observability/core/exporters/agent365_exporter_options.py Show resolved Hide resolved

juliomenendez approved these changes Nov 19, 2025

View reviewed changes

nikhilNava merged commit 4916c2e into main Nov 20, 2025
8 checks passed

nikhilNava deleted the nikhilc/addExporterOptions branch November 20, 2025 13:02

Conversation

nikhilNava commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants